Joinutility seperatorLogin utility separator Infobright.com
   
 
ICE source version control repository?
Posted: 14 September 2009 04:06 AM   Ignore ]  
Newbie
Rank
Total Posts:  4
Joined  2008-11-13

I’m starting to get bugged enough by the lack of status data about query execution that I begun to look at the source code for converting the notices written to bh.err into SHOW PROCESSLIST state information. Should be simple enough to insert a thd_proc_info() call in all places where the THD structure is passed along, and it would be a start. Most useful status data is coming from functions which don’t have a THD reference, but that’s phase two.

However, I hate working outside version control, so modifying the .tar.gz doesn’t fancy me, and I can’t find a link to an official repository. Clearly I can establish one on my own (and if I do, I’d probably post it on Launchpad and throw in the 3.0, 3.1 and 3.2 history in it if I can still find the tarballs for each), but just as clearly, an official repository that I could clone would be more preferable, so it would be simpler to generate and post a patch, too. So, is one out somewhere?

Profile
 
Posted: 16 September 2009 06:45 AM   Ignore ]   [ # 1 ]  
Jr. Member
RankRank
Total Posts:  82
Joined  2008-08-18

Hi,

I think this is great idea to synchronize query status that is written to bh.err with the one that is shown in PROCESSLIST.
Just one comment:

Most useful status data is coming from functions which don’t have a THD reference, but that’s phase two.

If you need a reference to THD object you may obtain it by calling:

ConnectionInfoOnTLS.Get().THD() 

in almost any place in Infobright’s optimizer.

Regarding official repository. Currently there is no one available. Please contact Mark Windrim (mark dot windrim at infobright dot org) for details of how to contribute and take a look at http://www.infobright.org/doc/contributor

Cheers

Profile
 
Posted: 17 September 2009 09:28 AM   Ignore ]   [ # 2 ]  
Administrator
Avatar
RankRankRankRank
Total Posts:  519
Joined  2008-07-08

Thanks Michal,

Just to close the loop - Osma and I have been in contact regarding this possible submission.

As for a source code repository, we’ve been moving to Git and ultimately GitHub.  We were on Launchpad at one time…

-Mark

Signature 
Profile
 
Posted: 17 September 2009 01:40 PM   Ignore ]   [ # 3 ]  
Newbie
Rank
Total Posts:  4
Joined  2008-11-13

Yup, thanks Michal and Mark. The approach to access THD works brilliantly, and I already tested a simple version of a patch to add status info to the processlist. Now to just iterate over plenty of queries and read the code to understand where are the best places to insert the state info. Unfortunately, I realized that for the most part, the bh.err output happens AFTER a certain time consuming operation, rather than just before it…

Profile
 
Posted: 18 September 2009 03:34 AM   Ignore ]   [ # 4 ]  
Sr. Member
Avatar
RankRankRankRank
Total Posts:  648
Joined  2008-08-18

Hi!

the bh.err output happens AFTER a certain time consuming operation

Well, it was done this way for the output brevity and to include the info available after the operation completes. Surely, to know what is going on a separate “start message” can be added. If you need some help around the code, ask.

Cheers

Profile
 
Posted: 21 September 2009 09:28 AM   Ignore ]   [ # 5 ]  
Newbie
Rank
Total Posts:  4
Joined  2008-11-13

Thanks all. I posted an initial version that helped me understand some of my more common queries at http://www.fishpool.org/post/2009/09/21/A-peek-under-the-hood-in-Infobright-3.2-storage-engine

This is pretty crude, but even so, I think very useful. I haven’t fully reviewed the contributor agreement yet, but as you can see, this being pretty trivial you could do a similar patch without it smile

Looking forward to seeing something like it also in IEE!

Profile
 
   
 
 
‹‹ Performance issue      Install failed... ››